Bug: Renaming item result in 2 files

files-community / Files

A modern file manager that helps users organize their files and folders.

https://files.community

MIT License

34.83k stars 2.21k forks source link

Bug: Renaming item result in 2 files #13265

Open sirinath opened 1 year ago

sirinath commented 1 year ago

Description

Re naming result in 2 files

Steps To Reproduce

Re name a file

Especially a zip file

Requirements

The previous file should not be there after a rename.

Files Version

2.5.21.0

Windows Version

10.0.22621.2134

Log File

debug.log

Josh65-2201 commented 1 year ago

Thanks for the report. What the name your expecting?

sirinath commented 1 year ago

I tried renaming the file Motivation for Giving.zip to Motivation for Giving - Long.zip. This resulted in 2 files. I would expect when you rename Motivation for Giving.zip to Motivation for Giving - Long.zip you should only have the file Motivation for Giving - Long.zip.

Josh65-2201 commented 1 year ago

Does refreshing the folder show the one file?

sirinath commented 1 year ago

No. I did that too.

Both files exist. I had to delete the file manually after the rename.

After deleting I had to refresh again. Then only it was not shown in the UI.

Josh65-2201 commented 1 year ago

Can you see if this is an issue in the preview version. https://files.community/download

sirinath commented 1 year ago

Even in the release version this happens very rarely. So cannot confirm if it is fixed.

yaira2 commented 1 year ago

Does this only happen in the downloads folder?

sirinath commented 1 year ago

I don't know if it happens only in the download folder.

yaira2 commented 1 year ago

@sirinath would you be able to upload a screen recording?

sirinath commented 1 year ago

https://github.com/files-community/Files/assets/637415/e4b5efd7-094d-43e2-8098-e47b4ea96be0

sirinath commented 1 year ago

Non download folder.

https://github.com/files-community/Files/assets/637415/44d2d207-1cc5-46e2-9bd7-3dbd1a0f6eb5

yaira2 commented 1 year ago

Is this only when dual pane is open? Can you also check if it's happening when turning off grouping?

sirinath commented 1 year ago

Single plane it still happens.

If you have the same directory open in 2 tabs and do the renaming in you you get this in the other tab:

If you rename without grouping and without dual panel it is fine but if you have dual panel you get something like:

Lukiluc29 commented 1 year ago

I can also replicate this issue in the latest preview version.

yaira2 commented 1 year ago

Thanks for the updates

sirinath commented 1 year ago

Another issue is if you disable dual panel nothing happens to the current tab. You still have dual panel.

If you close and open then again nothing happens if you have it set to start from where you left off.