search

files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
34.55k stars 2.2k forks source link

Bug: "Eject" appears in the context menu of the floppy disk drive #13462

Open hishitetsu opened 1 year ago

hishitetsu commented 1 year ago

Description

"Eject" should not be displayed because floppy disk ejection is not controlled by software. When I select "Eject" on the floppy disk drive, I get a drive-in-use error.

Steps To Reproduce

  1. Right-click a floppy disk drive on the drive widget.
  2. See "Eject" appears in the context menu.

Requirements

"Eject" should not appear in the context menu of the floppy disk drive.

Files Version

2.5.21.0

Windows Version

10.0.22631.2361

Log File

n/a

hishitetsu commented 1 year ago

Perhaps this should be addressed along with #10154.

0x5bfa commented 9 months ago

@hishitetsu Removed my assignment because I don't have floppy disk and I cannot test on the local. Feel free to fix this 🙇

yaira2 commented 2 months ago

Can this be checked using DriveType.FloppyDisk? Like @0x5bfa, it's hard for me to test this from my side.

hishitetsu commented 2 months ago

I can test it, but I really don't have time to code these days...