Bug: Searching from the Columns View displays the wrong context menu for files

files-community / Files

Building the best file manager for Windows

https://files.community

MIT License

34.16k stars 2.18k forks source link

Bug: Searching from the Columns View displays the wrong context menu for files #14058

Open lrstolk opened 10 months ago

lrstolk commented 10 months ago

What feature or improvement do you think would benefit Files?

Steps to reproduce

Switch to the Columns View
Start a search
Right click file and notice that the context menu is displaying the wrong options

Requirements

Fix issue where the context menu is displaying the wrong options

Files Version

v3.1.6

Windows Version

10.0.22631.2715

Comments

No response

Josh65-2201 commented 10 months ago

Thanks for the feedback,

Files uses the same system as Windows for search can you check they show in Windows File Explorer
Open File location is already in the context menu on search results
There is no reason to disable open in new tab as it work for search results too.
Can you send a screenshot of the wrong icons in the search bar and what they should be.

yaira2 commented 10 months ago

When I press open file in new tab, I get an a logical error. If it gives this error, why even enabling this option in the context menu?

Where do you see this option? It should only be available for folders.

lrstolk commented 10 months ago

Thanks for the feedback,

Files uses the same system as Windows for search can you check they show in Windows File Explorer

The results in windows file explorer do show them, so it is something with Files:

Open File location is already in the context menu on search results

There is no reason to disable open in new tab as it work for search results too.

Where do you see this option? It should only be available for folders.

look at my video at 0:28.

There is not.

Can you send a screenshot of the wrong icons in the search bar and what they should be.

What do you mean? It it shown in the video, please check it. At 0:06
I get these results. When I do it again at 0:17
the results are wrong. It is the same search. I searched, went to the folder, went back and searched again. The second time it bugged.

yaira2 commented 9 months ago

@lrstolk is the location you're searching indexed by Windows? The default setting in Windows is pretty limited so that would explain why Files isn't showing the expected results. You can solve this by switching to "Enhanced" or by adding the location to the search index.

lrstolk commented 9 months ago

@lrstolk is the location you're searching indexed by Windows? The default setting in Windows is pretty limited so that would explain why Files isn't showing the expected results. You can solve this by switching to "Enhanced" or by adding the location to the search index.

Well it shows the right results the first time I search, the first timeI search everything goed well, but not the second time it shows the wrong results in the preview and things as the context manu start to bug.

yaira2 commented 9 months ago

When you start the second search, are you going back to the original location or are you just changing the text in the search box and pressing enter?

lrstolk commented 9 months ago

When you start the second search, are you going back to the original location or are you just changing the text in the search box and pressing enter?

I go back, so I search by typing "238", press enter, go back, typing"238", press enter. Also the main problem is not solved, I got the latest version from 14 januari 2024.

Also check this videos to see my issues: https://github.com/files-community/Files/assets/35999180/e8cc8dbb-d3c2-4741-92e8-5fa01faea1d4

yaira2 commented 8 months ago

It's hard to follow the video but if you can summarize steps to reproduce the issue I'll see if I can repro it on my end. It might also be worth checking if you can repro this issue on a fresh install of Files without making any changes to the settings or layout modes.

yaira2 commented 8 months ago

@lrstolk are you by any chance starting the search while using the Columns View? If so, it's probably the same issue as #13311 and I'm able to reproduce the issue as well.

lrstolk commented 8 months ago

It's hard to follow the video but if you can summarize steps to reproduce the issue I'll see if I can repro it on my end. It might also be worth checking if you can repro this issue on a fresh install of Files without making any changes to the settings or layout modes.

What can I make more clear for you? Cause for me it is straight forward.

lrstolk commented 8 months ago

@lrstolk are you by any chance starting the search while using the Columns View? If so, it's probably the same issue as #13311 and I'm able to reproduce the issue as well.

I am, but as I've read that issue #13311, it is not the same.

yaira2 commented 8 months ago

Now that I'm able to reproduce the issue, I'll edit the description for future reference.

0x5bfa commented 8 months ago

Drive items are also shown on the flyout.