Code Quality: Reduce duplicated functionality classes

0x5bfa commented 5 months ago

Description

I'm planning to remove Utils namespace by moving classes to service or Files.App.Storage. Providing a single, simple and common way of accessing the application functionalities allows us to implement unit tests easily as well as enables us to maintain codes easily.

Services.App

[ ] IAppNavigationService
- (helper) MultitaskingTabsHelpers
- (helper) NavigationHelpers
[ ] IFileTagsService
- (helper) FileTagsHelper
- (watcher) FileTagsManager
- (service) FileTagsService
- (context) FileTagsContext
- (item) FileTagItem
- (item) TagsListItem
- (item) TaggedFile
- (utility) FileTagsDatabase
[ ] IGitService
- (helper) GitHelpers

Services.Storages

[ ] IStorageOperationService
- (utility) FileOperationsHelpers
- (utility) FilesystemHelpers
- (utility) FilesystemOperations
- (utility) IFilesystemHelpers
- (utility) IFilesystemOperations
- (utility) ShellFilesystemOperations
- (utility) ShellFileOperations2
[ ] IStorageEnumerationService
- (utility) UniversalStorageEnumerator
- (utility) Win32StorageEnumerator
[ ] IStorageCalculationService
- (utility) FileSizeCalculator
[ ] IStorageDevicesService
- (service) RemovableDrivesService
- (watcher) DrivesViewModel
- (watcher) DeviceManager
- (watcher) WindowsStorageDeviceWatcher & IStorageDeviceWatcher
- (helper) DriveHelpers
- (utility) RemovableDevice

Services.Windows

[ ] IWindowsRecycleBinService
- (helper) RecycleBinHelpers
- (watcher) RecycleBinManager
[ ] IWindowsQuickAccessService
- (service) QuickAccessService
- (watcher) QuickAccessManager
- (utility) PinnedFoldersManager
[ ] IWindowsLibraryService
- (watcher) LibraryManager
[ ] IWSLService
- (watcher) WSLDistroManager
[ ] IWindowsTaskbarService
- (utility) SystemTrayIcon
- (window proc) SystemTrayIconWindow
[ ] IWindowsShellService
- (item) ContextMenu, Win32ContextMenu
- (item) ContextMenuItem, Win32ContextMenuItem
- (helper) ShellFolderExtensions
- (utility) ShellLibraryEx
- (utility) ShellLibraryFolders
- (helper) ShellNewMenuHelper
- (item) ShellFileItem
- (item) ShellLibraryItem
- (item) ShellNewEntry

Classes to Remove

[ ] Move to HomeViewModel
- (helper) WidgetsHelpers

Gains

Better maintainability
Reduced duplicated classes
Better test experience when we are going to implement Unit tests.

Requirements

Use single service per a functionality

Comments

No response

yaira2 commented 5 months ago

This looks like a good breakdown, let's split each task into a separate PR for quality and code review purposes.

yaira2 commented 5 months ago

If someone plans to work on a specific service, please add a comment so we can prevent duplicate PRs.