Code Quality: Introduce Directory.build.props for shared properties

files-community / Files

A modern file manager that helps users organize their files and folders.

https://files.community

MIT License

34.41k stars 2.19k forks source link

Code Quality: Introduce Directory.build.props for shared properties #14826

Open 0x5bfa opened 8 months ago

0x5bfa commented 8 months ago

Description

as the title. Usage: https://github.com/microsoft/devhome/blob/main/Directory.Build.props

Concerned code

csproj and vcxproj files

Gains

Reduced lines.
Avoid forgetting to add required properties
Avoid duplications

Requirements

Add Directory.build.props in the root
Remove diplications

Comments

No response

yaira2 commented 5 months ago

Can we do this in stages, and start with the duplicate props first?

0x5bfa commented 5 months ago

Yeah starting from

<Platforms>x86;x64;arm64</Platforms>
<RuntimeIdentifiers>win-x86;win-x64;win-arm64</RuntimeIdentifiers>

would be good

yaira2 commented 2 months ago

@0x5bfa are we still on board for this? If I recall correctly, this was causing some configuration issues.

0x5bfa commented 2 months ago

Yeah this has great benefits but I think we can slowly adding properties to the shared one, like adding one by one and loading solution step by step on local because I couldn't locate the issue.