search

files-community / Files

Building the best file manager for Windows
https://files.community
MIT License
33.19k stars 2.12k forks source link

Bug: Double-byte characters don't show correctly on the preview pane #15118

Open ReiNarumiya opened 3 months ago

ReiNarumiya commented 3 months ago

Description

If you use shift-jis as character code in the text and you select the text file in the Files, the characters will be garbled and you won't be able to read them in the preview screen. If you use UTF-8 as character code in the text file, you will have no garbled characters and can read them normally in the preview screen. I will be grateful if you could fix it. Thank you.

Steps To Reproduce

  1. Write something in the text file using Shift-jis as character code and save it.
  2. Open Files and you select the text file and see the preview screen on the right side.
  3. You will see the characters are garbled and you can not read them properly.

Windows 11 Pro 23H2 OS 　22635.3420 Windows Feature Experience Pack 1000.22700.1003.0

Requirements

The expected behaviour will be that you can see the characters in the text file on the preview screen of "Files" even when you use Shift-jis as character code. Fix the issue when you see garbles characters on the preview screen of "Files" if you use Shift-jis as character code. (or if you use non-2bytes character code such as Shift-jis in you will see the issue. If you use 2bytes character codes such as utf-8, you will not see the issue on the preview screen.)

Files Version

3.2.3.0

Windows Version

10.0.22635.3420

Log File

2024-04-05 04:06:02.5373|Information|SIDELOAD: Checking for updates... 2024-04-05 04:06:03.4368|Information|SIDELOAD: Current Package Name: Files 2024-04-05 04:06:03.4371|Information|SIDELOAD: Remote Package Name: Files 2024-04-05 04:06:03.4373|Information|SIDELOAD: Current Version: 3.2.3.0 2024-04-05 04:06:03.4375|Information|SIDELOAD: Remote Version: 3.3.0.0 2024-04-05 04:06:03.4376|Information|SIDELOAD: Update found. 2024-04-05 04:06:03.4377|Information|SIDELOAD: Starting background download. 2024-04-05 04:06:05.2729|Information|Download time taken: 00:00:01 2024-04-05 04:08:19.7192|Information|SIDELOAD: Checking for updates... 2024-04-05 04:08:19.7699|Information|The app is being activated. Activation type: LaunchActivatedEventArgs 2024-04-05 04:08:20.5055|Information|SIDELOAD: Current Package Name: Files 2024-04-05 04:08:20.5058|Information|SIDELOAD: Remote Package Name: Files 2024-04-05 04:08:20.5060|Information|SIDELOAD: Current Version: 3.2.3.0 2024-04-05 04:08:20.5061|Information|SIDELOAD: Remote Version: 3.3.0.0 2024-04-05 04:08:20.5062|Information|SIDELOAD: Update found. 2024-04-05 04:08:20.5064|Information|SIDELOAD: Starting background download. 2024-04-05 04:08:22.7121|Information|Download time taken: 00:00:02

0x5bfa commented 3 months ago

Thanks for the feedback. We'd appreciate if you upload a log file rather than pasting content of log file.

Can you send a screenshot where you have the problem?

ReiNarumiya commented 3 months ago

snap000167

0x5bfa commented 3 months ago

Thanks!

It's a bit unrelated but you seems to have been notified of the needs of reinstalling Files. We have updated our degital certificate since the last one expired in March. Please install from our website as you did: https://files.community/download Thank you for using Files!

ReiNarumiya commented 3 months ago

Thank you very much!

yaira2 commented 1 month ago

Related to #13866

yaira2 commented 1 month ago

I'll check with the other contributors to see if supporting additional encodings is in scope for Files.

ReiNarumiya commented 4 weeks ago

I am thankful for keeping watching this issue. Thank you again for your efforts. The Files is excellent and, I think, the best software compared with other file-managing software such as Explorer. I adore the development team. Thx.