Feature: Support for theme packs

files-community / Files

Building the best file manager for Windows

https://files.community

MIT License

33.77k stars 2.16k forks source link

Feature: Support for theme packs #15297

Open hishitetsu opened 4 months ago

hishitetsu commented 4 months ago

What feature or improvement do you think would benefit Files?

We are going to support for displaying a background image. It would make the distribution of themes for Files easier if the theme could be changed by double-clicking on a theme pack file, which contains a background image and other theme settings.

Requirements

Theme pack files have .filestheme extension.
A theme pack file is actually a zip archive, which contains an image file for the background and a json file which stores theme settings.
If the user opens a theme pack file, Files applies the background image and other theme settings contained within it.

Files Version

3.3.6.0

Windows Version

10.0.22631.3447

Comments

No response

yaira2 commented 4 months ago

Thank you for your feedback

TimoNotThy commented 3 months ago

Wouldn't it make more sense to use CSS? How are the build-in "themes" currently implemented?

Josh65-2201 commented 3 months ago

CSS is for web browsers and Files isn't a web site or based on one. Currently there values in settings that get applied across Files code base in XAML

0x5bfa commented 3 months ago

We have zip extractor inside of the codebase so making .filestheme as zip is a good idea. We should register in our new database and show them like Windows Settings app does.

TimoNotThy commented 3 months ago

For ease of use I would not put it in any type of archive, this way it's easy to edit without having to unzip and zip constantly. Another solution would be to have it work like how Minecraft does texturepacks, having both folders and zip files work.

Josh65-2201 commented 3 months ago

You wouldn't have to un-zip and re-zip to edit and test, at most it will be import > edit what you want > export. That's really as small as it can go. It stored as a zip when finalized so that all the files are available and easy to move around. Windows themes work the same just under a different extension.

0x5bfa commented 3 months ago

No reason to edit by your own it probably makes worsen because once it break you have to creat new one with correct names and configurations. So as @Josh65-2201 said, being archive is good enough.

yaira2 commented 2 months ago

@hishitetsu I like this idea and I wanted to share some thoughts

as there are sometimes changes to the theming options, we'll need some sort of versioning system, or at least proper error handling to only import valid values.
it would be cool if this works with background images, we can probably copy the images to the app data folder.
we might need to add a "reset" option to the appearance settings UI.