search

files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
34.56k stars 2.2k forks source link

Bug: Relevant actions are missing when right clicking recent files #15418

Open yaira2 opened 6 months ago

yaira2 commented 6 months ago

Description

The option to run exe files is missing when right clicking items in the Recent Files widget.

Steps To Reproduce

  1. Right click exe file from the Recent Files widget
  2. Notice that the "Run as admin" option isn't displayed

Requirements

Those are just a few examples, there are other actions as well.

Files Version

v3.4.1

Windows Version

Windows 11

Log File

NA

16dango commented 6 months ago

@yaira2 Could I work on this?

Josh65-2201 commented 6 months ago

Yes

0x5bfa commented 5 months ago

Add them into RecentFilesWidgetViewModel and create commands only for home page.

https://github.com/files-community/Files/blob/895331a71673eb2195ae331c70f811be1de09df4/src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs#L430-L431

https://github.com/files-community/Files/blob/895331a71673eb2195ae331c70f811be1de09df4/src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs#L405-L417

This is not https://github.com/files-community/Files/labels/help%20wanted.

Ultimately, we should use unified context menu builder instead of spreading around widget view models.

yaira2 commented 5 months ago

@0x5bfa we've been working towards a single context menu builder.

yaira2 commented 5 months ago

@0x5bfa how about the "Set as" options? Do we have a way to check if the right clicked item is an image?

0x5bfa commented 5 months ago

@0x5bfa how about the "Set as" options? Do we have a way to check if the right clicked item is an image?

I think theres extension check.

yaira2 commented 3 months ago

The recent files widget doesn't expose a property with the file extension