search

files-community / Files

Building the best file manager for Windows
https://files.community
MIT License
32.96k stars 2.1k forks source link

Code Quality: Added a logger to send exception reports to Sentry #15618

Closed hishitetsu closed 2 weeks ago

hishitetsu commented 2 weeks ago

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...
hishitetsu commented 2 weeks ago

Sentry logger can be moved to Shared project?

Should Shared project have a dependency on Sentry?

0x5bfa commented 2 weeks ago

In order to log in other projects as well. There's request to log in BackgroundTasks project.

But we're going to merge first, I'll do that...

yaira2 commented 2 weeks ago

@0x5bfa in theory, we can put SentryLogger.cs and the dependency in a shared project.