search

files-community / Files

Building the best file manager for Windows
https://files.community
MIT License
32.96k stars 2.1k forks source link

Code Quality: Renamed ItemViewModel with ShellViewModel #15622

Closed 0x5bfa closed 1 week ago

0x5bfa commented 2 weeks ago

Resolved / Related Issues

Steps used to test these changes

None

yaira2 commented 2 weeks ago

What's the goals here?

0x5bfa commented 2 weeks ago

Preparing Storage Abstraction (planning to finish codebase preparation in June or early July). This is long term goals but it's to refactor to reduce code lines of ShellViewModel. Current code base relies on this class and makes us hard to create unit test or maintain.

This PR's rationale is this class is the view model of IShellPage and name of ItemViewModel may confuse us with StandardStorageItem(fka ListedItem).

yaira2 commented 2 weeks ago

This PR seems to just be a rename, how does it further that goal?

0x5bfa commented 2 weeks ago

Wdym, I just made it more accurate. Besides being inside of Data.Models was also wrong.

d2dyno1 commented 1 week ago

Good change! Hopefully it'll be less confusing