files-community / Files

Building the best file manager for Windows
https://files.community
MIT License
32.92k stars 2.1k forks source link

Code Quality: Bring properties window to foreground on loaded #15636

Closed 0x5bfa closed 1 week ago

0x5bfa commented 1 week ago

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files app
  2. Open file properties window
  3. See brought to foreground
0x5bfa commented 1 week ago

@yaira2 Found easy one 😄 Honestly my helper class is strong!

yaira2 commented 1 week ago

Did this fix the issue for you? On my end it's still an issue.

yaira2 commented 1 week ago

We had a similar issue with widgets (see #11433).

0x5bfa commented 1 week ago

When I first try to repro, I removed existing files and I thought it fixed (it sure poped up to the foreground). @yaira2 I did the same thing but no progress here. I seemed to have been wrong...