files-community / Files

Building the best file manager for Windows
https://files.community
MIT License
32.92k stars 2.1k forks source link

Code Quality: Bump CsWin32 to latest available #15637

Closed AArnott closed 1 week ago

AArnott commented 1 week ago

This simplifies some of our code, and eliminates the compiler warnings we saw from the Files.App.Server project due to that version being particularly old.

Resolved / Related Issues

I'm actually volunteering this PR in response to an issue a Files community member filed against CsWin32, when it actually wasn't a bug there, but just old code in this repo.

Steps used to test these changes

I launched the program according to your README file, but the Files.App.Server.dll apparently never even loaded, so I don't know how to test it.

0x5bfa commented 1 week ago

apparently never even loaded, so I don't know how to test it.

Thank you for testing, we have disabled to launch this server in order not to drop Admin launch (WinRT out-of-process apparently doesn't support RunAs).