files-community / Files

Building the best file manager for Windows
https://files.community
MIT License
32.89k stars 2.1k forks source link

Feature: Added support for choosing the dual pane orientation #15680

Open 0x5bfa opened 5 days ago

0x5bfa commented 5 days ago

Summary

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files app
  2. Open the menu
  3. Click 'Split pane' item
0x5bfa commented 16 hours ago

@yaira2 because the text ShowTabActions has button and the control type of ToggleSwitch is button thus the text includes the control type name, the AXE test is failing. Could you consider text that doesn't include button?

image


Two to-do is remaining.