files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
34.6k stars 2.2k forks source link

Bug: Mouse back/forward buttons highlight hovered pane #15706

Open rivahere opened 4 months ago

rivahere commented 4 months ago

Description

When in dual pane mode, when I hover over the unfocused pane and use my back/forward buttons on my mouse, it will highlight the pane as if it is now in focus but the focus is still on the other pane.

Steps To Reproduce

1.) Open dual pane mode. 2.) Use hardware forward/backward navigation keys on the pane opposite to the one in focus. 3.) Notice the hovered pane is highlighted but not focused

Requirements

Files Version

3.5.0.0

Windows Version

Windows 11 Pro 22621.3810

Log File

debug.log

yaira2 commented 4 months ago

Is this request that clicking on the mouse back button should focus the hovered pane?

rivahere commented 4 months ago

Is this request that clicking on the mouse back button should focus the hovered pane?

yes, instead of having to click it twice or the primary mouse button. As it is now, it highlights as if it focuses it but isn't actually focused.

yaira2 commented 4 months ago

I understand you'd prefer for the hovered pane to be selected, but the concern is that this can be confusing. In the meantime thought, I think we should fix the issue and make sure that only the selected pane is highlighted.

hishitetsu commented 4 months ago

I found that pressing the back/forward button on the unfocused pane will highlight and focus that pane. This behavior is same as Edge. Should this behavior still be changed?

yaira2 commented 4 months ago

It's okay with me then, if the standard practice is to focus the hovered pane, the main thing is to be consistent.