search

files-community / Files

Building the best file manager for Windows
https://files.community
MIT License
33.85k stars 2.17k forks source link

Feature: Display option to skip when item is too big for Recycle Bin #15764

Open WCKYWCKF opened 2 months ago

WCKYWCKF commented 2 months ago

Description

WCKYWCKF commented 2 months ago

Sorry, there are some problems with the translation.It translates bug as vulnerability.I've revised the title.

I'll provide a more detailed reproduction of the bug here. to help you guys fix it.

  1. Create an item that cannot be accommodated in the Recycle Bin. image
  2. Create a folder and put some files in it. Anyway, as long as you delete it in Windows File Explorer without prompting you with "The file is too big to put in the Recycle Bin".
  3. Select them both in Files and then delete. image image 4.This will result in this error message. image image debug.log
0x5bfa commented 2 months ago

How big the file is? I'm stuck at this kind of error message to show during operation in the storage abstraction layer.

@yaira2 if we were able to show error message, how do we show it? Content dialog or small notification info bar in Status Center?

WCKYWCKF commented 2 months ago

@0x5bfa It doesn't matter how big the file is. The problem is that the Recycle Bin can't hold the files you want to delete. You can refer to Windows File Explorer. When you delete multiple items at the same time and some of them can't fit in the Recycle Bin, Windows File Explorer will extract the items that can't be put into the Recycle Bin and ask you individually what to do with them.

yaira2 commented 2 months ago

How big the file is?

You can change the size of Recycle Bin from File Explorer.

if we were able to show error message, how do we show it? Content dialog or small notification info bar in Status Center?

A content dialog