files-community / Files

Building the best file manager for Windows
https://files.community
MIT License
33.82k stars 2.16k forks source link

Can't type in text field in customization in a folder properties #15941

Open Steperman5692 opened 1 month ago

Steperman5692 commented 1 month ago

Description

I was going to change the icon of a folder but it wouldn't let type inn the text field it would only let me select icons from shell32.dll. There is a workaround tho, by clicking the "Browse" button i can select my icon file but faster for me to just type it out :(

Steps To Reproduce

  1. Right click a folder and select properties.
  2. Go to customization menu.
  3. Try to type into the text field and it wouldn't work :(

Requirements

It wouldn't let me type in the text field in the customization menu in a folder properties

Files Version

3.5.0.0

Windows Version

22631.3958

Log File

debug.log

yaira2 commented 1 month ago

@Steperman5692 thank you for reaching out, the path box is read only by design and the correct workflow is to click browse. Can you confirm if the browse popup works properly?

Steperman5692 commented 1 month ago

Yeah its works perfectly fine but it would be nice if we can type the the text field :(

0x5bfa commented 1 month ago

Well, we can make it acceptable, while we need error handling for path validation (with TeachingTip?)

Steperman5692 commented 1 month ago

wdym by that?

0x5bfa commented 1 month ago

It was to @yaira2 I'm not sure we'll plan to prioritize but this is pretty easy work.

Steperman5692 commented 1 month ago

that would be pretty nice :D

yaira2 commented 1 month ago

Yeah its works perfectly fine but it would be nice if we can type the the text field :(

We prefer using the dialog as it has validation and error handling built in.

Josh65-2201 commented 1 month ago

You can also type the path/filename in the path box of the dialog

Steperman5692 commented 1 month ago

it's just nicer it we can type in it :(

yaira2 commented 1 month ago

I get your feedback, I haven't made a final decision so it's still under consideration.