files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
34.43k stars 2.19k forks source link

Bug: Soft link file details layout information misaligned #15998

Open zuoxinyu opened 2 months ago

zuoxinyu commented 2 months ago

Description

image

Steps To Reproduce

  1. create a softlink file (via mklink, not a Windows shortcut file) under a git project
  2. switch to Details layout

Requirements

soft link file has the same alignment with other files

Files Version

3.6.0.0

Windows Version

10.0.22631.3958

Log File

no

Josh65-2201 commented 2 months ago

Thanks for the report, I reproduced this issue and have added this to the project board.

piyushchouhan commented 2 months ago

I could not able to see any missalignment of detail of the sortcut created by mklink in git repos.

kunallohaniya commented 2 months ago

I am a beginner and this is my first time i'm here, it will be very helpful for me if someone let me know, how can i make contributions to the open source.

0x5bfa commented 2 months ago
  1. Build the project referencing the instructions described here
  2. Enumerated items are converted into ListedItem derivative classes such as GitItem and ShortcutItem
  3. I guess IsGitItem is false while should be true as checking if item is git one is done after checking if item is shortcut one.
  4. So if (isGitRepo) {} should be the first checking

The actual UI code that displays git info (as you can see IsGitItem handles if the element should be x:Load'ed): https://github.com/files-community/Files/blob/8fe155cd2376e5029675b04a0dd11c0b1db2963e/src/Files.App/Views/Layouts/DetailsLayoutPage.xaml#L1019-L1089

If you have questions, let me know!

priadiliav commented 1 month ago

Based on my testing, I was unable to reproduce the issue. It is possible that this problem has already been fixed in a recent update.

Josh65-2201 commented 1 month ago

I can still reproduce this, Make sure you following the steps to reproduce when testing

priadiliav commented 1 month ago

Apologies, you're right—I didn't simulate the exact issue. Now I can clearly see the problem, and I'm going to resolve it.

Could you please assign this issue to me?

image