search

files-community / Files

Building the best file manager for Windows
https://files.community
MIT License
33.84k stars 2.17k forks source link

Improve handling of permission elevation #16009

Open Hissymaster opened 1 month ago

Hissymaster commented 1 month ago

Description

for whatever reason, deleting files permanantly from the recycle bin is... odd...

Steps To Reproduce

  1. go to the recycle bin folder "Shell:RecycleBinFolder"
  2. select a folder with many subfolders.
  3. attempt deleting it
  4. refresh
  5. it's back? why?

Requirements

Files Version

3.6.1.0

Windows Version

10.0.22631.4037

Log File

debug.log

0x5bfa commented 1 month ago

Thanks for reaching out.

How many (approx) did you delete?

Hissymaster commented 1 month ago

It appears to struggle with handling files managed or owned by an administrator account? Or at least an account in a higher level than a normal user.

Hissymaster commented 1 month ago

It not just the recycle bin. I don't think the program is properly handling UAC elevation.

Hissymaster commented 1 month ago

It appears to me that when it runs into a folder OR FILE that needs more permissions that a base user, it fails to properly ask or elevate and everything falls apart, but files doesn't properly catch that.

0x5bfa commented 1 month ago

Thanks for the heads up.

Hissymaster commented 1 month ago

It affects any action. And although it appears to be complete in the status centre, refreshing tells you otherwise.

STGYO commented 1 month ago

I am also facing the same issue here. If I want to empty my recycle bin from the files app in the sidebar, the file is not getting deleted at all and remains in the folder. I can only go to the desktop to empty my recycle bin. But from the desktop the recycle bin folder from the files app is not opening by double-clicking at all.

Hissymaster commented 1 month ago

And it also appears files struggles with a lot of bulk delete, bulk move and other bulk actions

Hissymaster commented 1 month ago

it also seems to struggle deleting empty folders, if that helps.

0x5bfa commented 1 month ago

it also seems to struggle deleting empty folders, if that helps.

Is that folder lesser permission? Like, you (if you're admin Administrators group otherwise Users group, more specifically your own) don't have permission of 'Delete' access control?

Hissymaster commented 1 month ago

It doesn't matter if you're admin. It won't delete empty folders.

0x5bfa commented 1 month ago

I meant if you have sufficient permission to delete it.

Hissymaster commented 1 month ago

Even if you have sufficient permissions, it doesnt work

Hissymaster commented 2 weeks ago

it appears to be fixed in the latest preview.