search

files-community / Files

Building the best file manager for Windows
https://files.community
MIT License
34.13k stars 2.18k forks source link

Bug: Files fails to make an archive if there's an issue with a file #16240

Open Josh65-2201 opened 3 weeks ago

Josh65-2201 commented 3 weeks ago

Description

Creating an archive in 7zip errors like file not found and file locked by another process will be shown in an errors list and continue to attempt to make the archive. Files will just fail and cancel the entire archive.

Steps To Reproduce

  1. Create a sys link in a folder (mklink /j "<Path to folder>" "<Path to store location>")
  2. Create an archive of the folder with the syslink store folder in
  3. Files will cancel compression but 7zip will report that it can't find the file and continue

Requirements

Files Version

3.7.7

Windows Version

10.0.22631.4169

User ID

3372b393-b294-495c-9814-4e5b48d9fd8d

Log File

debug.log

yaira2 commented 2 weeks ago

Should users be prompted to continue?

Josh65-2201 commented 2 weeks ago

7zip doesn't have one and I don't think it needs one, but if a dialog is going to be used to warn the user then I guess there should be a cancel and continue button on it.