search

files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
34.59k stars 2.2k forks source link

Bug: Files crashes with memory error when browsing files with file preview enabled #16254

Open SeleDreams opened 1 month ago

SeleDreams commented 1 month ago

Description

While browsing source code files of a C program I'm working on with file preview enabled, big files or browsing multiple small files next to each other will cause Files to crash with an out of memory error (although my system still has ram, it seems more like a windows security feature). I am on the microsoft store version.

{9D27E316-BB5B-401F-8E08-8917D0604FF1}

Steps To Reproduce

  1. Start Files
  2. Enable file preview
  3. Highlight files until it crashes

Requirements

Ensure that Files doesn't crash when checking out files.

Files Version

3.7.7.0

Windows Version

10.0.22631.4169

User ID

No response

Log File

debug.log The log doesn't appears to say anything interesting.

SeleDreams commented 1 month ago

It actually does not appear to be a "crash". It's a pretty interesting case where it seems a windows security feature kicks in where it is most likely warning of a memory leak by saying people could abuse of the memory buffer overrun to run malicious code. Files still is working perfectly fine in the background, but the moment I close the prompt warning of the memory issue, windows closes Files.

Josh65-2201 commented 1 month ago

Thanks for the report.

yaira2 commented 1 month ago

Can you reproduce this with #16156?

yaira2 commented 1 month ago

Is this still an issue in the preview version? https://files.community/download/preview

Josh65-2201 commented 3 weeks ago

Is this still an issue in 3.7.11?