files-community / Files

Building the best file manager for Windows
https://files.community
MIT License
34.1k stars 2.18k forks source link

Bug: Some files types take a while to open #16286

Open andrew-james-heard opened 1 week ago

andrew-james-heard commented 1 week ago

Description

sometimes, but only sometimes, when I press Enter on a file (eg. LibreOffice writer .odt or calc .ods) the application takes ages to open. It appears to stall. I discovered if I kill Files.exe from Sysinternals Process Explorer that the application opening resumes. I get the impression Files has temporarily/ incorrectly locked the file. If I open the application from Start menu instead of indirectly by file association, then never a problem. Seems to have started recently. Doesn't happen with Explorer.

Steps To Reproduce

  1. select a file with cursor+Up/ Down
  2. press Enter
  3. default app associated with file will be opened, and passed the path
  4. observe (sometimes) the sequence is delayed because, maybe, Files.exe has not let go of the file?

Requirements

Files Version

3.7.9

Windows Version

10.0.22631.4169

User ID

a89c587c-81e1-4f41-826c-5c87169b5c2b

Log File

debug.log

andrew-james-heard commented 1 week ago

Yair - please update the Summary to something you know is better.

yaira2 commented 1 week ago

@andrew-james-heard do you know which file formats have this issue? We have two different code paths for launching files and depending on the file extension, we use the method that works best.

andrew-james-heard commented 1 week ago

I mentioned LibreOffice writer .odt & calc .ods. I use them the most & are the only ones I've only experienced this huge (like a minute+) slowdown. A bit more than "a while". Delete Files.exe & instantly the opening continues.

andrew-james-heard commented 1 week ago

unrelated but when ctrl+shift+N is used to create a new folder the textbox no longer has focus, you have to press Tab 1st; doesn't seem worth creating a new bug report for that; pretty sure it used to be the case after ctrl+shift+N you just started typing the name

yaira2 commented 3 days ago

That is an issue with WinUI and will hopefully be resolved on their end.

andrew-james-heard commented 3 days ago

WinUI for ctrl+shift+N? Can't be 100% but thought it only started happening recently. Write your own "Enter an item name" dialog? image

andrew-james-heard commented 3 days ago

I just upgraded to 3.7.10 & now the textbox above has initial focus in the dialog when ctrl+shift+N is pressed. Expected?

yaira2 commented 3 days ago

v3.7.9 had a newer version of WinUI we were testing.

andrew-james-heard commented 3 days ago

3.7.9 had the reported issue, apparently fixed (changed?) in 3.7.10; it's only a very minor point