Code Quality: Rename "Files.App (Package)" to "Files.Package" in the directory tree

files-community / Files

A modern file manager that helps users organize their files and folders.

https://files.community

MIT License

34.22k stars 2.18k forks source link

Code Quality: Rename "Files.App (Package)" to "Files.Package" in the directory tree #16350

Open Lamparter opened 2 days ago

Lamparter commented 2 days ago

Description

It's unnecessary and somewhat confusing to have the name "Files.App (Package)" in the directory tree (src). It should better be named Files.Package to match the configuration manager.

Concerned code

N/A

Gains

Better understanding of folder structure
Developer will understand the link between "Files.App (Package)" and "Files.Package" as it appears in the editor.

Requirements

Rename directory "Files.App (Package)" to "Files.Package"

Comments

No response

0x5bfa commented 2 days ago

moving appxmanifest to another place would break the auto update

0x5bfa commented 2 days ago

To rename, Files.App.Package makes more sense but we'd not rename or move until msixbundle is supported in the single packing project.

Lamparter commented 2 days ago

To rename, Files.App.Package makes more sense but we'd not rename or move until msixbundle is supported in the single packing project.

Yes you're right, like in FluentHub. However, that's how it currently is (Files.Package in Configuration Manager)

yaira2 commented 2 days ago

https://github.com/files-community/Files/pull/12475#issuecomment-1566150396

Lamparter commented 2 days ago

It's possible to publish a package from a single package project though, right?

I think it's like that in Rebound 11.

yaira2 commented 2 days ago

Bundles aren't supported yet