search

files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
34.45k stars 2.19k forks source link

QuickLock Integration #348

Closed FelixZacher closed 4 years ago

FelixZacher commented 4 years ago

QuickLock integration

https://github.com/QL-Win/QuickLook

I have a early working prototype.

At the moment i can toggle QuickLock by launching an application. So it's basically possible.

Things to Do

  1. Communication between App and Launcher. At the moment i misuse the "Launching Application" signal for toggeling QuickLock. I would appreciate some input on how the communication should be designed.
  2. Settings UI, where you can enable the Integration.
  3. How QuickLock should be launched (key stroke, context menu, etc.). Most comon way is by pressing spacebar. Is there anything against using spacebar?
yaira2 commented 4 years ago

By using the space bar it would be by holding it down for a few seconds?

szaimen commented 4 years ago

@yaichenbaum IMO, pressing the spacebar once (not holding it down) should open QuickLook. So that it is like on macos.

(Pressing the spacebar once again while QuickLook is open should close it and refocus the latest FilesUWP Tab. But that is probably an issue that QuickLook has to solve...)

yaira2 commented 4 years ago

I imagine this will only be if QuickLook is installed so I guess it wont affect regular users.

FelixZacher commented 4 years ago

QuickLock provides a NamedPipe, where you can send the toggle-Command.

At first toogle-Command the preview window is shown, at the second-command the preview window is closed again or shows a new file preview, if a new path is send.

@yaichenbaum I would include a settings option, where you have to turn the feature on, if you want to use it and if you have QuickLock installed.

yaira2 commented 4 years ago

I wouldn't bother with a setting for it, if the user has it installed then it should work without any extra setup from the user.

yaira2 commented 4 years ago

Thank you @lampenlampen for the amazing job you did with this!

FelixZacher commented 4 years ago

Icon

QuickLook has an icon we can use.

I'm no expert in license stuff. For me it seems that QuickLook is under the GPL 3, which gives us the permission to use it.

yaira2 commented 4 years ago

I am fairly sure we can use it as long as we credit the source, the about page in the app would probably be the best place to reference it.

yaira2 commented 4 years ago

Just pointing out that the way Files is setup right now is that new features in the right click context menu need to be added to the photo view as well as the standard list view. In the future this will be changed in to one control but until then it needs to be implemented twice.