files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
34.51k stars 2.2k forks source link

Feature: Add digital signatures tab to properties window #3723

Open PMExtra opened 3 years ago

PMExtra commented 3 years ago

Describe the solution/problem

image

I want to view and verify the digital signatures info in Files. I think we can add a tab in properties and show the signature details directly.

Requirements

Files version

2.3.12.0

Windows version

10.0.19043.2006

PMExtra commented 3 years ago

@yaichenbaum Please let me know if you'd like to implement it or welcome the PR.

yaira2 commented 3 years ago

@PMExtra A PR would be great, would you like to work on this?

yaira2 commented 2 years ago

I think we need a design before approving, keeping in planning for now.

yaira2 commented 11 months ago

As far as design goes, we can do something similar to the hashes page.

0x5bfa commented 9 months ago

I found that C# crypt API doesn't work properly; X509Certificate2UI.DisplayCertificate displays different certificate information from the FE one and X509Certificate.CreateFromCertFile is capabble of getting only one signature.

I'll go with CryptUIDlgViewCertificateW in Win32API. API example is here.

For others who will work on this area in the future.

renanalencar commented 2 weeks ago

Wow! This feature would be nice to have in Files app!

Lamparter commented 2 weeks ago

Here's a mock-up in case it would be useful 🙂

0x5bfa commented 2 weeks ago

This is what I implemented before but I discarded due to inactivity.

Image

yaira2 commented 2 weeks ago

That looks great! Do you still have the code for it?

mr-costaalencar commented 2 weeks ago

If I had time, I would like to develop this feature.

0x5bfa commented 2 weeks ago

@yaira2 I forgot to create a draft pr to leave the changes... but I can tell someone who'd like to work on this what native API should be used.