files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
34.78k stars 2.21k forks source link

Feature: Add support for file type icon overlay #7243

Open VOOM108 opened 2 years ago

VOOM108 commented 2 years ago

What's the Problem?

In Explorer, thumbnails have, or can be set to have, filtype-icons as overlays. This helps to discern a JPG from a PSD or afphoto etc. Also, videos and images or PDFs are hard to discern without any indication of the filetype.

In medium or large icon view, even the filenames are usually cut off so that the extensions are not visible, either.

Solution/Idea

Have files show the filetype-icons as overlays the way Explorer does. (It is possible, that this is not native to explorer, but there is a setting in Sage Thumbs which leads to that kind of overlay)

Alternatives

No alternative ideas

Priorities

Capability Priority
This proposal will allow end users to discern the filetype in thumbnail views Must

Files Version

2.0.34.0

Windows Version

Windows 10 Pro Version 21H1 Betriebssystembuild 19043.1348

Comments

No response

gave92 commented 2 years ago

~Thanks for the report. This is unfortunately a known issue, e.g #6966, #6512.~ Edit: I misread, this is different. Could you post a screenshot of Explorer showing this?

VOOM108 commented 2 years ago

The missing thumbnails / thumbnails not being refreshed etc. are an issue here, too. But I saw, that that is a known issue.

I hope the image makes clear, what I mean. When it comes to discerning images, videos and PDFs, it is even more disturbing, but knowing if what I see is the .afphoto with layers, or a .png exported flat also makes working with files hard...

no-filetype-icons

VOOM108 commented 2 years ago

Also, I see much more text, up to 4 lines, in Explorer, but only one line in Files. So the filetype extension is visible even more seldom...

yaira2 commented 10 months ago

Is this still an issue in the preview version? https://files.community/download/preview

VOOM108 commented 10 months ago

The length of the filename shown is better now, but there still are no file type icon overlays on any file type.

yaira2 commented 10 months ago

Can you confirm if you're using v3.1.2?

VOOM108 commented 10 months ago

Yesterday's download was 3.1.1

Edit: it seems to be 3.1.2 though in 'about' it says 3.1.1

VOOM108 commented 10 months ago

Sorry, when I checked the version, it was the not preview build. But here is what it looks like with the 3.1.2

image

yaira2 commented 10 months ago

Thanks for checking! Is there a way to enable these overlays without sage thumbs?

VOOM108 commented 10 months ago

I don't think they have anything to do with SageThumbs. They are a regular Windows feature. Some apps like Irfanview or ImageGlass provide different file type icons for different kinds of images, but Windows has the ability to show them natively, I think.

yaira2 commented 10 months ago

They are a regular Windows feature

I can't seem to find an option to enable them

Josh65-2201 commented 9 months ago

No, it's an option in Sagethumbs not Windows. Other programs can add there own when generating thumbnails too.

It also seem that Sage is directly editing how Windows File Explorer thumbnails works to get them to show.

yaira2 commented 9 months ago

Are they directly hooking into File Explorer to display them? We can discuss adding our own option to Files but this doesn't seem to be a native option in Windows.

Josh65-2201 commented 9 months ago

Not sure, The installer shows a few dlls being modified but they seem to just be for registering that the program is installed.

yaira2 commented 9 months ago

Apparently, there is a reg key you can add. REG ADD "HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced" /V ShowTypeOverlay /T REG_DWORD /D 1 /F

VOOM108 commented 9 months ago

That is already set in my case, otherwise Explorer would not show the overlays.