search

filestack / filestack-android

Official Android SDK for Filestack - API and content management system that makes it easy to add powerful file uploading and transformation capabilities to any web or mobile application.
https://www.filestack.com
Apache License 2.0
154 stars 90 forks source link

Display detailed upload progress in notification #155

Open shawnmaten opened 6 years ago

shawnmaten commented 6 years ago

It was intended from the start to have detailed upload progress notifications for individual files.

There are 2 major blockers to enabling this.

The first thing that needs to be solved is this issue in the Java SDK. filestack/filestack-java#51 The base SDK was supposed to provide the necessary progress updates for this, as a stream of progress objects from the upload observable, but that isn't working. And looking at the code now, I did not understand how parallelism was working in RX. So that all needs to be sorted out but I think the idea of the RX interface is fine, it's just not straightforward to have RX be parallel. (I still might be really lacking in RX understanding here.)

The other thing is that the UploadService needs some work. The IntentService won't work with non-blocking code. If we subscribe to an observable for the upload, we won't be blocking, and the service would just quit. So instead of an IntentService we need a base Service or maybe something else. And more recent versions of Android have introduced tougher restrictions to prevent battery draining (there's now a job scheduling system, JobIntentService, other things I've skimmed in press releases) so we should conform to that.

mtariquekhan commented 6 years ago

Hi shawnmaten, Is there any update related to progress percent while uploading file. We need this to include in our project to show progress to the user while uploading.

shawnmaten commented 6 years ago

Added to internal tracker: https://filestack.atlassian.net/browse/FS-3356

shawnmaten commented 6 years ago

@mtariquekhan I don't have an update on this right now but it's still planned to be fixed.

mhswtf commented 5 years ago

Is there any new progress on this issue?

mtariquekhan commented 5 years ago

is there any progress @shawnmaten?

shawnmaten commented 5 years ago

Hey just a heads up @mhswtf and @mtariquekhan I no longer work at Filestack so I wouldn't know about any internal progress on this. You might try mentioning the most recent committer or sending an inquiry through Support.