search

filestack / filestack-angular

An official angular component library for the Filestack
MIT License
9 stars 10 forks source link

fix(picker): Compatibility issues with Angular 10 #35

Closed ravianand1988 closed 2 years ago

ravianand1988 commented 2 years ago

Description

This PR fixes the Angular 10 complaining to must have a decorator for the components. It refactors the picker base component name from component to directive too to be aligned with Angular conventions/linting rules.

In order to pass the tests, tests for filestack service have been refactored as necessary.

Note: My goal here is to add the support of Angular next versions that are [11, 12, 13]. However, I would open them as separate PRs after fixing the current issues. :crossed_fingers:

ravianand1988 commented 2 years ago

@AndrzejSala @pcholuj @MowiliMi Could you please add your review to this PR. We are stuck since we are trying to update our projects with Angular next versions [11, 12, 13]. This one is blocking us, unfortunately. :crossed_fingers: