filestack / filestack-js

Official Javascript SDK for the Filestack API and content ingestion system.
https://www.filestack.com
MIT License
206 stars 79 forks source link

`CropFiles` breaks drop pane success callback #350

Closed IanVS closed 4 years ago

IanVS commented 4 years ago

I noticed that my drop panes are no longer working. I tried turning off cropFiles, and they work. But if I turn cropping on, I never get a call to my onSuccess or onError callbacks. I see a few console logs from picker.js, but that's it.

wfifer commented 4 years ago

Thankfully caught this before demoing some image-based features—our bad for not pinning the version. Looks like 3.12.4 is fine, if that helps for now.

pcholuj commented 4 years ago

Hi @IanVS Can you provide your dropPanel config ?

mminkoff commented 4 years ago

@pcholuj I can confirm seeing the same behavior on 3.15.0.

{
  maxSize: 1024*1024*5,
  imageMax: [1024,1024],
  accept: "image/*",
  displayMode: "dropPane",
  container: "#answer-drop-pane",
  dropPane: {
    onProgress,
    onSuccess,
    customText,
    showIcon: false,
    cropFiles: true
  },
  cleanupImageExif: {
    keepOrientation: true,
    keepICCandAPP: true
  },
  transformations: {
    crop: {
      aspectRatio: 8/6
    },
    rotate: true,
    force: true
  }
}
IanVS commented 4 years ago

Sorry, I've left the team where I hit this issue, I can no longer provide the config, but it looks like @mminkoff has. Thanks!

pcholuj commented 4 years ago

We will be checking this problem soon.

pcholuj commented 4 years ago

Fixed in newest release