[Fix] (sentry-416): use Sentry v6 version

filestack / filestack-js

Official Javascript SDK for the Filestack API and content ingestion system.

https://www.filestack.com

MIT License

206 stars 76 forks source link

[Fix] (sentry-416): use Sentry v6 version #419

Closed thinhvo0108 closed 3 years ago

thinhvo0108 commented 3 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix
What is the current behavior? (You can also link to an open issue here) See #416
What is the new behavior (if this is a feature change)? Use Sentry's v6.1.0 (from v6, the hub.startSession is used)

thinhvo0108 commented 3 years ago

Got inspired from @namoscato (https://github.com/filestack/filestack-js/pull/417)

namoscato commented 3 years ago

@thinhvo0108 – FYI I pushed up another commit to https://github.com/filestack/filestack-js/pull/417 that also bumps this version. It might be best to try and consolidate all of this in one PR.

thinhvo0108 commented 3 years ago

Cool, thanks @namoscato we can just use 1 fix, your fix (I mean)

I didn't include the package-lock.json as our local node/npm version may affect the changes, so I will include after confirming what current npm version is being used by our Filestack folks at the moment!

namoscato commented 3 years ago

I didn't include the package-lock.json as our local node/npm version may affect the changes

I think this will just affect the version of @sentry/minimal installed with filestack-js.