fix(sentry): remove problematic Sentry integration

filestack / filestack-js

Official Javascript SDK for the Filestack API and content ingestion system.

https://www.filestack.com

MIT License

206 stars 76 forks source link

fix(sentry): remove problematic Sentry integration #488

Open namoscato opened 1 year ago

namoscato commented 1 year ago

Resolves #467 Resolves #482

What kind of change does this PR introduce?

Bug fix and arguably breaking change
What is the current behavior? (You can also link to an open issue here)

The current Sentry integration:
1. records unhelpful errors (see https://github.com/filestack/filestack-js/issues/467)
2. is incompatible with Sentry's latest version (see https://github.com/filestack/filestack-js/issues/482) which will be a recurring problem (see https://github.com/filestack/filestack-js/issues/416)
What is the new behavior (if this is a feature change)?

This removes the Sentry integration in favor of users implementing this at their application layer, which seems simpler and more appropriate.

namoscato commented 1 year ago

@sebastian-wec, @pcholuj – do you have any thoughts on this change? This is currently blocking our ability to upgrade to Sentry's latest major version.

BenGale commented 1 year ago

This seems to be causing us issues too when upgrading to the latest version of sentry.

ryan-gray-db commented 1 year ago

@johnkoehn Hey, I see this is approved. How do we go about getting this merged?

johnkoehn commented 1 year ago

No clue @ryan-gray-db, I just approved it for the heck of it. All the engineers at filestack left after the company was acquired. It is a dead product.

ryan-gray-db commented 1 year ago

No clue @ryan-gray-db, I just approved it for the heck of it. All the engineers at filestack left after the company was acquired. It is a dead product.

Haha, that's good to know... We had no idea. Thank you!

namoscato commented 1 year ago

@sethk4783, @Yaminim07, @prem-celestial, @hemanth-3, @RatGabi (with recent activity in this repository) – are you able to help get this change shipped?

@johnkoehn and I have been repeatedly requesting that this pull request be merged for nearly a year. Unfortunately, the delay in addressing this matter has significantly hindered our ability to upgrade Sentry to its latest version across our applications.

artemgurzhii commented 2 months ago

@namoscato I have tried to use your branch in the package.json, but it was throwing some errors, so tried to create my own fork and make it work. in case anybody needs - "filestack-js": "uplisting/filestack-js#chore/remove-sentry", works for me. link - https://github.com/uplisting/filestack-js/tree/chore/remove-sentry