filestack / filestack-rails

Official Ruby on Rails plugin for Filestack File Picker that makes it easy to add powerful file uploading and transformation capabilities to any web or mobile application.

https://www.filestack.com

Apache License 2.0

223 stars 102 forks source link

Fix helper without options renders faulty JS #201

Closed diegous closed 5 years ago

diegous commented 5 years ago

200 Filestack Form Helper with no options renders javascript syntax error

Simply moving #{json_string} (line 71) to the end of the object fixes this, but I had a hard time reading this code so I took the liberty of refactoring a little bit

coveralls commented 5 years ago

Coverage increased (+0.01%) to 97.183% when pulling c02a98e18ef3a290f827b0a8aedd02e13ab8ab62 on diegous:patch-2 into 68ca7245000e44f30f48d13a3da1ac1949e1604a on filestack:master.

gabifija commented 5 years ago

Already fixed!