search

filestack / filestack-rails

Official Ruby on Rails plugin for Filestack File Picker that makes it easy to add powerful file uploading and transformation capabilities to any web or mobile application.
https://www.filestack.com
Apache License 2.0
223 stars 101 forks source link

Custom CNAME not used for Javascript script include #226

Closed JoshReedSchramm closed 4 years ago

JoshReedSchramm commented 4 years ago

In: https://github.com/filestack/filestack-rails/blob/4c672d67038b54136f198cfe72a43ee4391ce55e/lib/filestack_rails/filestack_js.rb#L9

If you provide a custom cname in the configuration that cname is ignored when including the javascript script tag. This is problematic if the purpose of setting a custom cname is to ensure that all traffic from filestack comes from a domain you control. (In our case we are doing this to avoid corporate firewall blocking of filestack.io, filestackcontent cdn, etc.)

gabifija commented 4 years ago

Hello @JoshReedSchramm ! Thank you for letting us know. I've already fixed the issue in filestack-rails 5.2.2. Thanks!