search

filestack / filestack-react

Official React component for Filestack - API and content management system that makes it easy to add powerful file uploading and transformation capabilities to any web or mobile application.
https://www.filestack.com
MIT License
164 stars 41 forks source link

new folder organization, new styleguides, refactoring. #5

Closed samuxyz closed 7 years ago

samuxyz commented 7 years ago

As the repo is now maintained by Filestack as well here I changed a few things.

  1. Separated demo files in /examples/demo, the folder /examples (guess what!) is the folder where we are going to add more and more small examples. In the future we may think to decouple the webpack configurations for each example as well.
  2. Refactored ReactFilestack: I moved the line to import filestack-js to the top of the file and got rid of log. Now, when users do not pass onSuccess and onError the default props come in and log either the result or error in the console. Furthermore, I moved the client initialization in a separate function.
  3. Added the security object.
  4. Moved the webpack loaders in a separate file webpack.loaders.js.
  5. Added a few rules in the eslint configuration to adhere to AirBnb styleguides and linted the code before making the PR (should become a default step I guess).
  6. Updated the README with the security object prop and me as contributor.

I am not sure who is going to review the PRs from now on but anybody is welcome.

ZeroCho commented 7 years ago

Do I have to merge it? Or will you guys in filestack?

samuxyz commented 7 years ago

@ZeroCho I asked but it's night there, for now no worries. Thanks.

dubsquared commented 7 years ago

Thanks @samuxyz, lgtm. We're going to work on a proper Filestack contribution guide, but as discussed, the airbnb style is preferred for now.