filestack / filestack-ruby

Official Ruby SDK for Filestack - API and content management system that makes it easy to add powerful file uploading and transformation capabilities to any web or mobile application.
https://www.filestack.com
Apache License 2.0
34 stars 27 forks source link

unirest uses old version of rest-client #17

Closed sina-s closed 6 years ago

sina-s commented 6 years ago

I'm not able to use this gem due to conflicting rest-client gem version with some other gems I have in my project. One of the gems require rest-client >= 2.0 and filestack-ruby requires unirest which requires the older rest-client (~> 1.6.7). I would have opened an issue upon unirest but it seems like it's unmaintained and there are a bunch of other old dependency issues in there: look at https://github.com/Kong/unirest-ruby/issues/45 and https://github.com/Kong/unirest-ruby/issues/33

pmichaeljones commented 6 years ago

Any suggestions guys? rest-client 1.6.7 has a known vulnerability, but since Filestack has a dependency on unirest 1.1.2 it's impossible to update rest-client without removing Filestack-Ruby.

gabifija commented 6 years ago

We will fix the issue in new version of Ruby SDK

thejspr commented 6 years ago

Awesome @gabifiolek! Any idea when this new version will be released?

pmichaeljones commented 6 years ago

Hey @gabifiolek Any idea on an update?

pmichaeljones commented 6 years ago

Hey @thejspr @sina-s It's quite easy to roll your own implementation. I used HTTParty and it was a cakewalk. Might be the best choice because there doesn't seem to be a timeframe for this update.

gabifija commented 6 years ago

@sina-s we actually updated the library to version 2.3.0 with some changes.