search

filestack / filestack-ruby

Official Ruby SDK for Filestack - API and content management system that makes it easy to add powerful file uploading and transformation capabilities to any web or mobile application.
https://www.filestack.com
Apache License 2.0
34 stars 27 forks source link

Feature/fs 114 add common mixin #2

Closed staturecrane closed 7 years ago

staturecrane commented 7 years ago

Adds Common Mixin and Multipart/V1 Uploading

This PR represents tasks FS-114 and FS-1057, the common mixin and multipart uploading, respectively.

I hewed closely to the Python library for the multipart, but essentially wrote it from scratch to ensure it was working with/without security, was passing in user parameters correctly and was sending and receiving the right headers. One major change from the last merge is that I replaced Typhoeus with Unirest as Typhoeus was not sending headers correctly and seems to no longer be actively maintained.

staturecrane commented 7 years ago

I have a Rubocop plugin for my IDE, but I will go back and run it in the terminal as well. I know there were a couple of things in the multipart uploads, so I will try to address those.