Replace gem mimemagic by marcel

filestack / filestack-ruby

Official Ruby SDK for Filestack - API and content management system that makes it easy to add powerful file uploading and transformation capabilities to any web or mobile application.

https://www.filestack.com

Apache License 2.0

34 stars 27 forks source link

Replace gem mimemagic by marcel #81

Closed keymastervn closed 3 years ago

keymastervn commented 3 years ago

Related issue #80

coveralls commented 3 years ago

Coverage increased (+0.007%) to 96.64% when pulling 1927388068712aad157810022195a88a2b443690 on keymastervn:migrate-mimemagic-to-marcel into 9660deada070a28543cd34b24760d82003df27e9 on filestack:develop.

keymastervn commented 3 years ago

    filestack was resolved to 2.9.1, which depends on
      marcel (~> 1.0.0) was resolved to 1.0.0, which depends on
        ruby (>= 2.2)

Aye, gem marcel did not support ruby < 2.2, should we bump the next major version? 🤔

gabifija commented 3 years ago

@keymastervn I've replaced mimemagic with mini_mime in version 2.9.2. Let me close this PR.