search

filestack / filestack-ruby

Official Ruby SDK for Filestack - API and content management system that makes it easy to add powerful file uploading and transformation capabilities to any web or mobile application.
https://www.filestack.com
Apache License 2.0
34 stars 27 forks source link

Replace URI encode to ERB #91

Closed 14113 closed 1 year ago

14113 commented 2 years ago

Closes #89

URI.encode has been deprecated since ruby 2.7

New

URI::Parser.new.escape '<html>this and that</html>'
=> "%3Chtml%3Ethis%20and%20that%3C/html%3E"

Old

URI.encode '<html>this and that</html>'
=> "%3Chtml%3Ethis%20and%20that%3C/html%3E"
"%3Chtml%3Ethis%20and%20that%3C/html%3E" == "%3Chtml%3Ethis%20and%20that%3C/html%3E"

Missing tests :(

tomaskubala commented 2 years ago

@gabifija Hey Gabi, could you check this PR please? We are getting some deprecation warnings. We are using filestack-rails but it depends on this gem. I can't see the Coverall report, but locally tests are passing. Thank you for your time.

14113 commented 2 years ago

Any update? Maybe it's time to do our own fork?

taylorthurlow commented 2 years ago

Would be great to see this merged, it doesn't look altogether that complicated of a change and Ruby 3 has been out for... well over a year now.

mjstallard commented 2 years ago

➕ 1 to this - we're 7 months out from Ruby 2.7 end-of-life, so this will become a blocker for anyone who wants to remain on a maintained version of Ruby.

jandudulski commented 1 year ago

Any chance to release that?

14113 commented 1 year ago

I don't think so.

carlwiedemann commented 1 year ago

cc @gabifija Can you remark whether this project is still officially supported by filestack?

gabifija commented 1 year ago

@carlwiedemann I am no longer part of the Filestack team. I do not know who is currently responsible for this project.

carlwiedemann commented 1 year ago

@gabifija Ok, thanks for letting me know. We'll try to get in touch with them another way.