search

filibuster-testing / filibuster-java-instrumentation

Filibuster instrumentation for the JVM.
http://filibuster.cloud
Apache License 2.0
15 stars 4 forks source link

LCS computation crosses key boundaries. #67

Open cmeiklejohn opened 1 year ago

cmeiklejohn commented 1 year ago

LCS algorithm used in the ResponseBecomesRequest analyzer considers field names. The LCS should be restricted in such a way that it only considers the values for each key. Therefore, something should basically truncate/stop the LCS if it sees either (A) end of line, indicating that we're moving to a new field or (B) colon, which is used to separate key from value.

cmeiklejohn commented 1 year ago

probably would be easier if we recorded the actual GeneratedMessageV3's