search

filicious / core

Filicious is a high level object oriented filesystem abstraction for PHP.
https://filicious.github.io/
31 stars 9 forks source link

listFiles must honor globbing better #36

Open discordier opened 11 years ago

discordier commented 11 years ago

listFiles() should not fetch all files and filter them after then.

For slow FS this is plain evil.

i.e.: glob = lib/*

FTP fetches all dirs in root but could rule all except fot /lib out forehand.

tristanlins commented 11 years ago

According to our call you wan't recursive glob patterns like lib/**, not recursive listing with globing.

leofeyer commented 11 years ago

When you are working on this, you might want to look into the Symfony Finder improvements.

http://symfony.com/blog/new-in-symfony-2-2-finder-improvements https://gist.github.com/jfsimon/3230139 https://github.com/symfony/symfony/pull/4061

They are using native commands where available instead of the PHP functions.

tristanlins commented 11 years ago

We need to check the performance and implementation details.