search

filidorwiese / ripple-wallet

Lightweight command-line Ripple wallet (node based)
ISC License
41 stars 19 forks source link

Ripple addresses are between 25 and 35 characters in length? #9

Closed ahdavis181 closed 6 years ago

ahdavis181 commented 6 years ago

https://github.com/filidorwiese/ripple-wallet/blob/46c37ad3e17bab989477a3004e3f621b78857b47/scripts/pay.js#L21

According to https://ripple.com/build/accounts/#address-encoding, Ripple addresses are between 25 and 35 characters in length. The RegExp in pay.js only allows addresses between 27 and 35 characters in length?

filidorwiese commented 6 years ago

You're totally right. Thanks for the heads up! I've improved Ripple address validations in version 1.1.0, which is out now at npm.