search

filipdutescu / modern-cpp-template

A template for modern C++ projects using CMake, Clang-Format, CI, unit testing and more, with support for downstream inclusion.
The Unlicense
1.69k stars 214 forks source link

[BUG] Build workflows have errounous CMake options #10

Closed filipdutescu closed 4 years ago

filipdutescu commented 4 years ago

Describe the bug The build actions do not reflect changes made in commit 38337bc to the macro names. It is not registered as an error, but CMake warns about it:

CMake Warning:
 Manually-specified variables were not used by the project:

   ENABLE_CODE_COVERAGE

To Reproduce Steps to reproduce the behaviour:

  1. Go to the Ubuntu action,
  2. Click on the last run (at the time of the writing, this one),
  3. Click on the build job and open the configure step,
  4. Scroll down until the CMake warning

Expected behaviour All options provided to CMake should be name properly and should function as described in the cmake/StandardSettings.cmake file.

Screenshots N/A

Desktop (please complete the following information): Rather than a PC, the following refers to the GitHub Actions' container:

Additional context N/A