filipdutescu / modern-cpp-template

A template for modern C++ projects using CMake, Clang-Format, CI, unit testing and more, with support for downstream inclusion.
The Unlicense
1.69k stars 214 forks source link

Remove redundant newline ('\n') characters on end the message. #17

Closed ghost closed 4 years ago

ghost commented 4 years ago

The message() command of the CMake inserts newline on the end of its argument.

codecov-commenter commented 4 years ago

Codecov Report

Merging #17 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1974980...f64f3d3. Read the comment docs.

ghost commented 4 years ago

@filipdutescu Hi... thanks for the feedback. One reason I removed the newlines that it really makes no difference with or without \n when they at the end of message() command. I mean, the output will be stay as is, because the message function implicitly assert a newline to end of its argument. In fact, I never saw such a practice on any CMake file on the open source projects that I look into.

filipdutescu commented 4 years ago

@p1v0t it adds an empty line between the current one and the next. But I have no problem with removing it to be fair. Especially if it is so uncommon. Thanks for the input.

filipdutescu commented 4 years ago

@p1v0t one problem, however. You made a change concerning #18 and no issue was created for the newline problem.

If you can create 2 PRs and the additional issue for newlines and we can merge (since it goes against the Contributing guidelines).

If you are unable to do that, please let me know, so I can get onto it, thanks.