search

filipdutescu / modern-cpp-template

A template for modern C++ projects using CMake, Clang-Format, CI, unit testing and more, with support for downstream inclusion.
The Unlicense
1.73k stars 215 forks source link

C++ version printed as blank ootb #32

Open vadi2 opened 2 years ago

vadi2 commented 2 years ago

Getting this in the logs:

[cmake] -- Applied compiler warnings. Using standard .

vadi2 commented 2 years ago

This could be fixed with:

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)

Using the latest published standard would make sense for a greenfield C++ project.

filipdutescu commented 2 years ago

Awesome catch! Thanks for providing a solution as well. Will work to merge it in the next couple of weeks, alongside the other issues and create a release.