filipdutescu / renamer.nvim

VS Code-like renaming UI for Neovim, writen in Lua.

Apache License 2.0

298 stars 11 forks source link

[Bug] Changes is nil on any rename. #106

Closed aloussase closed 2 years ago

aloussase commented 2 years ago

Describe the bug

I get an error saying that changes is nil everytime I rename something. The renaming itself looks like it's working correctly though.

To reproduce

Steps to reproduce the behavior:

Rename a symbol

Expected behavior

The symbol is renamed and no errors occur.

Environment

Renamer: v3.0.3
Neovim: v0.6.0
OS: Pop! OS 21.10

Screenshots

Additional context

Just installed it and run its setup function providing only the title. Then I am calling the rename function through a mapping.

txtyash commented 2 years ago

Same issue: https://imgur.com/a/mBqqwM4

filipdutescu commented 2 years ago

Interesting, no clue why this is happening but will investigate and come up with a fix. Can I get the name of the LSP server's you are using?

aloussase commented 2 years ago

I was using ccls: https://github.com/MaskRay/ccls

filipdutescu commented 2 years ago

Could you switch temporarily to the develop branch and tell me if it isn't fixed? I worked on another issue with a similar problem and reworked the logic that breaks for you and @zim0369. The related issue was GH-100.

filipdutescu commented 2 years ago

I have just checked and it still reproduces on latest develop. Figured out why, now working on a fix.