filipdutescu / renamer.nvim

VS Code-like renaming UI for Neovim, writen in Lua.

Apache License 2.0

298 stars 11 forks source link

Fix offset_encoding error #118

Closed abzcoding closed 2 years ago

abzcoding commented 2 years ago

Credit goes to @razak17

Motivation

Fixes #117

Proposed changes

get client offset_encoding from client
set it when calling apply_workspace_edit

Test plan

Test it on latest neovim 0.7 head, observe that it works without issues

dsully commented 2 years ago

Any chance this can be merged?

lewpoly commented 2 years ago

Any chance this can be merged?

Would also like to know. Commenting for visibility.

NishanthSpShetty commented 2 years ago

filipdutescu commented 2 years ago

Hello, I will close this PR as I am working on a more resilient fix for GH-117. I have also posted a detailed update there, for everyone wondering about this bug. Expect a fix to come out before next Friday.

filipdutescu commented 2 years ago

Thank you very much @abzcoding for creating this PR and working on the workaround! I am sorry I will not include you contribution at the current moment, but please, if you want to make others, feel free to do so as I really appreciate all support and suggestions!

abzcoding commented 2 years ago

no worries mate <3