Closed felipowsky closed 8 years ago
@felipowsky man, I finally got a time to make the modifications that I've suggested on the previous PR but to be honest your way looks more clearly now.
It made me re-think the other style properties, my way looks too complicated to understand now (I'm distant of this project for a long time), maybe I refactor to looks like your approach to Custom View.
So I'm merging this PR and soon I'll launch a new version on Cocoapods to make it available.
Again: Thank you so much for contributing, and sorry about the delay, from december until now I'm on a bureaucratic process of move to São Paulo and other things.
Ok, @filipealva. Thanks for replying. Don't worry about the delay. Your project helped me a lot so my contribution was the least I could do to thank you. Good luck with your move to São Paulo. :)
Summary of what I've done:
row
parameter added anindex
parameter. This parameter is pretty handy when dealing with an infinite PickerView.row
is theindexPath.row
from the internaltableView
while index is the index consideringindexPath.row % items.count
Added a new function delegate to know when a row was tapped:pickerView(PickerView, didTapRow row: Int, index: Int)
UIPickerViewDelegate
. The names of function delegates were working fine but I prefer to work with their names as close as Apple's.Related pull request: https://github.com/filipealva/PickerView/pull/5