search

filipegoncalves / rust-config

Configuration file library in Rust similar to C/C++'s libconfig
MIT License
20 stars 10 forks source link

Update to nom 1.0 #12

Closed Geal closed 9 years ago

Geal commented 9 years ago

Hi!

nom 1.0 is here, and comes with a few breaking changes. To help the transition, and to test the beta version before release, I took the liberty to test and upgrade (if needed) your code to the 1.0 version. It should work right away, but if there are still issues, or if the code needs to be updated to your latest master, please let me know!

If you want an explanation of the changes, please take a look at the upgrading documentation.

By the way, could you go to one (or all) of those links and write a few kind words about your experience writing parsers in Rust? It would really help me!

Thank you for using nom!

filipegoncalves commented 9 years ago

Thanks, travis builds were broken because you mistakenly deleted use nom::IResult; but other than that it looked good (also, had to add a complete! in an optional component of a chained parser).

I will write very good things about nom and I intend to start contributing again!

Geal commented 9 years ago

great, thanks! Please tell me if you see other bugs :)