search

filipemunhoz / performance-api-webflux-vs-mvc-vs-golang

Comparing performance on APIs running on Spring MVC, Spring Webflux and Go
13 stars 11 forks source link

Wrong Assessment About Test Envrionment #1

Open batuhancaglayan opened 3 years ago

batuhancaglayan commented 3 years ago

Hello Filipe,

I read you Medium article. I examined and tried your benchmark. I am not Go expert but i think there are two missing on your benchmark. So that i think the results are not correct.

  1. Your test scenarios are not same. In the Spring Webflux project, you are calling another endpoint with webclient over http request. ( jmetter => spring webflux endpoint, to call other service endpoint over http => spring webflux endpoint ) But in the Go example, after to handle http request, you are triggering a method call. ( jmetter => go endpoint , call other method in same reqeust )

You can check that easly on a network sniffer like wireshark. You need to create same environment for compare these two service. But they are quite different from each other.

  1. What is your test environment hardware specs ? I think you need to specify your test environment specs. For example, " i provides 1 gb ram and 1 core for all services. " If they are different from each other, they will give unhealthy results.

If i have a mistake, you can correct me and i will say oww it is my mistake. But If i don't have mistake, you need to specify correct environment and re-make your benchmark and set alight on your code and on your Medium article.

RassulYunussov commented 2 years ago

https://github.com/filipemunhoz/performance-api-webflux-vs-mvc-vs-golang/pulls

RassulYunussov commented 7 months ago

Repo is not actively maintained. I've bumped all the versions and added Helidon

https://github.com/RassulYunussov/performance-api-webflux-vs-mvc-vs-golang

Pool request was waiting for years: https://github.com/filipemunhoz/performance-api-webflux-vs-mvc-vs-golang/pull/2