search

filipesilva / angular-quickstart-lib

MIT License
305 stars 75 forks source link

Suggestion: Lightweight gh-pages #28

Closed Crazyht closed 7 years ago

Crazyht commented 7 years ago

Deploy SystemJS to gh-pages in state is little heavy (copy node_modules), but normally all node packages can be accessed by https://unpkg.com/... so may be best way is to create script which copy /src/demo in temp folder replace path for 'npm' from 'node_modules/' to 'https://unpkg.com/' and deploy temp folder as gh-pages.

What do you think about this ? I'm wrong ? (and optionally this script can be integrate to travis process for success build)

filipesilva commented 7 years ago

No, you're not wrong, that's a good approach. It's just that this repro tries to follow the quickstart format, and make the least possible changes. While doing that has it's benefits, it's one more thing to explain for a particular scenario.

filipesilva commented 7 years ago

Also, overall it would be much better to bundle the app using Angular CLI, or rollup+aot.