search

filipesilva / angular-quickstart-lib

MIT License
305 stars 75 forks source link

Inlining doesn't actually work in the demo app #57

Closed lazarljubenovic closed 7 years ago

lazarljubenovic commented 7 years ago

Even though inlining succeeds and both out-tsc and dist folders contain properly inlined CSS, the server that's run with npm run start command is not actually inlined.

image

I'm not sure if this is by design, but this causes problems with my setup of SCSS, since I cannot see the proper version of the lib in the demo app. The SCSS gets imported into browser, Angular runs it through parser, and spits out a mutant monster which ain't valid CSS.

image

So technically it doesn't cause problems in this demo and everything works if you use CSS, but I believe this is not expected behavior -- developers expect to see their bundled lib loaded as it's bundled, not as it was written.

lazarljubenovic commented 7 years ago

Ah, never mind -- I got carried away by previous development using webpack and replaced my styleUrls with .scss extension. Of course that wouldn't work in the environment.